Battery gauge fix #52
Conversation
|
@philippe44, I assigned the review to you since you have a better point of view from the SqueezeAmp angle! |
…ge-fix * upstream/master-cmake: WIP User Interface improvement. Fix SqueezeAmp build - release WIP - User Interface improvements
|
I'm fine with the C change, the JS part is really your realm @sle118 |
|
There's a formatting hell here, making it difficult to figure out the difference. I'll take some time to review other the weekend. @rochuck thank you for submitting this |
|
Would you mind pulling the latest changes and reapplying you changes, please? To save flash space, I completely reformatted the js file with tabs instead of spaces, and that makes it difficult to spot the changes. |
|
@sle118 This should be fine as is. How are you looking at the changes? The diff here: https://github.com/sle118/squeezelite-esp32/pull/52/files is pretty clean, to my eyes. |
|
Ok, I see it now. I was looking at the wrong place |
|
Additional comment: the status.json handles numerical values with a double internally, so there shouldn't be a change needed in the status cJSON calls. |
…to master-cmake * 'master-cmake' of github.com:sle118/squeezelite-esp32: fix a couple of gpio names (SPI/I2C) New config UI for Services (Airplay, bt, etc) - release Add nvs "wifi_ps" to disable wifi power save mode - release Battery gauge fix (sle118#52)
* master-cmake: fix a couple of gpio names (SPI/I2C) New config UI for Services (Airplay, bt, etc) - release Add nvs "wifi_ps" to disable wifi power save mode - release Battery gauge fix (sle118#52) WIP User Interface improvement. Fix SqueezeAmp build - release WIP - User Interface improvements
This PR fixes the battery voltage reporting to the Web UI. status.json was reporting an integer value for the battery voltage. The ranges have also been updated to what I think are more reasonable values.