New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer with source and copyright info missing #90

Closed

bananica opened this issue Dec 8, 2021 · 7 comments · Fixed by #102

Labels

Collaborator

bananica commented Dec 8, 2021

bananica added the enhancement label

Collaborator Author

bananica commented Dec 16, 2021

I've added this one to the bottom of the doctors list and to the single dr page. Last change date is missing atm, not sure if we can get it.

jalezi linked a pull request

that will close this issue

Redesign: 💙 blue #102

Merged

Contributor

lukarenko commented Dec 20, 2021

@stefanb we do not have timestamp files yet, right?

Member

stefanb commented Dec 20, 2021

nope, issue is sledilnik/zdravniki-data#4

Member

stefanb commented Dec 26, 2021

Timestamps added in sledilnik/zdravniki-data#4:

General footer should display the latest of the two, but we could also start with one of them.

Member

stefanb commented Dec 27, 2021

Cc @bananica @jalezi

Contributor

lukarenko commented Dec 27, 2021 via email

We should just use timestamp of doctors.csv

On Mon 27 Dec 2021, 08:25 Štefan Baebler, ***@***.***> wrote: Cc @bananica <https://github.com/bananica> @jalezi <https://github.com/jalezi> — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALFQ26L2XORP3BNMB4L7MOLUTAIGXANCNFSM5JSV2WIQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

Member

stefanb commented Apr 1, 2023

This was done in

feat: ✨ add timestamps #173

And related... https://github.com/sledilnik/zdravniki/search?q=timestamp+&type=commits

stefanb closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment