Add swift4 keyPath support #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 2, 2017
Closed
|
@kenji21, thanks for the PR! Would you be able to add a test for |
|
Sure, I was trying to also add support multiline strings with antlr (but it's a bit out of my knownledge, so it will take some time) |
|
@adityatrivedi the swift3 #keyPath is still present in Macros.swift:110 :-) |
|
Ok, just got the correct g4 syntax to have multiline string managed. Should I do another PR, or update this one ? |
|
@kenji21 lets go a new PR for the multiline string fix :) |
|
PR for the multiline sent : #496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\ can now be used to specify keyPaths, so I added one usage in Macros.swift and patched the grammar file
See : https://github.com/apple/swift-evolution/blob/master/proposals/0161-key-paths.md and https://developer.apple.com/library/content/documentation/Swift/Conceptual/Swift_Programming_Language/zzSummaryOfTheGrammar.html