Pin Node version to 15.3 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the deploy on dev worked with this change? |
|
Also putting this here for context. The reason for this change was an issue with deploys on dev where files were getting wiped. Debug log can be found here: https://bighealth.atlassian.net/wiki/spaces/PE/pages/110855099/01+25+2021+-+Deploys+broken+on+dev |
vladdyk
approved these changes
Jan 26, 2021
|
@nmguse-bighealth just a merge here will roll it out to all envs, correct? |
nmguse-bighealth
approved these changes
Jan 26, 2021
|
@avi-bh I double-checked legacy and it looks like the webhook was missing from legacy-qa/production. I'll manually trigger those so they are built and I have an open PR to get the webhook added so it'll be taken care of automatically in the future. Platgen is all good, that is all setup to auto-trigger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧷 Node to 15.3
Serverless deploy was wiping a bunch of files in the deployment package. It's apparently related to a new Node version.
serverless/serverless#8794