Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions for Node 16 #36

Merged
merged 9 commits into from
Nov 29, 2023
Merged

Conversation

sleighzy
Copy link
Owner

@sleighzy sleighzy commented Nov 28, 2023

Upgrades for GitHub actions for CI and fixes for linting and Molecule tests

  • Upgrade GitHub actions to actions/checkout@v4 and actions/setup-python@v4 due to Node 12 deprecation.
  • Add support for Docker cGroups v2 to the containers used for testing
  • Install ps command into test Docker containers to detect that Kafka is running
  • Use FQDN for role task names
  • Additional fixes for linting errors

Upgrade GitHub actions to actions/checkout@v4 and actions/setup-python@v4 due to Node 12 deprecation:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Migrate to molecule-plugins for installing the docker plugin as these have moved in Molecule 5.

Add support for Docker cGroups v2 to the containers used for testing, note that in addition to cgroupns_mode the rw is flag needed which was previously ro

volumes:
      - /sys/fs/cgroup:/sys/fs/cgroup:rw
cgroupns_mode: host

Use the ansible-lint GitHub action as the lint plugin is not present as part of the Molecule tests and linting can be performed separately.

@sleighzy sleighzy merged commit 9c444c6 into master Nov 29, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant