Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for laravel 5.3 #24

Merged
merged 7 commits into from
Sep 18, 2016
Merged

support for laravel 5.3 #24

merged 7 commits into from
Sep 18, 2016

Conversation

helloiamlukas
Copy link
Contributor

No description provided.

@sleimanx2
Copy link
Owner

sleimanx2 commented Sep 10, 2016

I prefer to keep the 5.2 support , what do you think ?

@helloiamlukas
Copy link
Contributor Author

As far as I can see the only relevant thing that changed in 5.3, is that the QueryBuilder now returns a Collection instead of an array (see here). So I guess if you want to keep the 5.2 support, you need to check every time if the result is a Collection or a array.
Sorry for the incomplete push request, I should've run the tests on my local machine before :-) I'm pretty new to this stuff, but your project is really nice and I thought I could help you with this.

@sleimanx2
Copy link
Owner

If that's the only place that we should change in order to keep backward compatibility than okey why not.

@sleimanx2
Copy link
Owner

I think we should still need to update the getLast method even though we are not using it right now

then we should be able to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants