Added port ranges to received specifications #48
Conversation
There was a problem hiding this comment.
Thanks again for your contribution!
I'll merge this, but it would be nice if you could send another PR to address my comment about return 1 vs. return -1, and also add a few tests to parsetest.c to verify the new code—and to make sure that it won't be broken by later changes.
| { | ||
| char *newarg=(char *) malloc (strlen (argv[j]+1)); | ||
| if (!newarg) | ||
| return 1; |
There was a problem hiding this comment.
I would prefer return -1, because that's the convention for error codes in the rest of the code. (Repeats here in a few places.)
| suffix++; | ||
| for (int k=first;k<=last;k++) | ||
| { | ||
| char *newarg=(char *) malloc (strlen (argv[j]+1)); |
There was a problem hiding this comment.
I had to convince myself that this length is always sufficient. The (decimal representation of) the port number can become larger by incrementing, but the total length should not exceed the original length when you include the range specification. So that looks fine.
So now this is legal:
127.0.0.1/7301
also this
127.0.0.1/7301-7310 (means create receivers on port 7301 to 7310 inclusive)
also this
127.0.0.1/7301+10 (means create 10 receivers starting at 7310, so it's the same as above).