Add default first line support

slemarchand · Nov 1, 2016 · dee8da6 · dee8da6
1 parent a484430
commit dee8da6
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 1 deletion.
diff --git a/lib/xlsx.js b/lib/xlsx.js
@@ -37,7 +37,7 @@ var extractFromExcel = function(excelPath, config, path) {
 	*/
 
 	var defaultConfig = {
-
+		firstLine: 1,
 		escape: false
 	};
 

diff --git a/test/acceptance/data/xlsx-test/from_xlsx_config_default_first_line.json b/test/acceptance/data/xlsx-test/from_xlsx_config_default_first_line.json
@@ -0,0 +1,8 @@
+{
+    "keyColumn": "B",
+    "valueColumn": "D",
+    "filter": {
+    	"column": "C",
+    	"value": "go"
+    }
+}
diff --git a/test/acceptance/xlsx-test.js b/test/acceptance/xlsx-test.js
@@ -60,6 +60,26 @@ describe("props from-xlsx", function() {
 
   });
 
+  it("extract properties file from XLSX file, supporting default first line", function() {
+
+    var inputFilePath =  base + '/from_xlsx_input.xlsx';
+
+    var configFilePath = base + '/from_xlsx_config_default_first_line.json';
+
+    var intoFilePath = base + '/from_xlsx_into.properties';
+
+    var expectedFilePath = base + '/from_xlsx_expected.properties';
+
+    main.run(['from-xlsx', inputFilePath, configFilePath, intoFilePath]);
+
+    var actualContent = fse.readFileSync(intoFilePath, 'utf8').toString();
+
+    var expectedContent = fse.readFileSync(expectedFilePath, 'utf8').toString();
+
+    expect(actualContent).to.equal(expectedContent);
+
+  }); 
+
   it("extract properties file from XLSX file, supporting multiple sheets", function() {
 
     var inputFilePath =  base + '/from_xlsx_input_multiple_sheets.xlsx';