Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio .def exports file needs to be updated (or use __declspec) #105

Closed
ewmailing opened this issue Mar 16, 2015 · 2 comments
Closed

Comments

@ewmailing
Copy link

The exports .def file is extremely out of date. This is needed to correctly build dynamic libraries on Windows.

This is a continuing problem. It would be nice if you started using __declspec hidden behind macros to annotate which APIs are public/exported directly in the header files. This would also have the added benefit of being reusable for gcc/clang which have visibility attributes which restrict which APIs to export (which can shrink the binary and speed up link times).

@slembcke
Copy link
Owner

Adding them using macros is a really good point. In the past I avoided them because they made the headers "ugly". That's why I used to do the .def file, but you are right that it really is a problem.

@slembcke slembcke self-assigned this Jun 29, 2015
@slembcke slembcke modified the milestone: 7.0.1 Jun 29, 2015
@slembcke
Copy link
Owner

slembcke commented Jul 1, 2015

7f8d668

@slembcke slembcke closed this as completed Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants