[revisions] improve test coverage on JaversRevisionService

corolla-backend/corolla-backend-domain-commons/src/main/java/com/tocea/corolla/revisions/services/JaversRevisionService.java

@@ -190,7 +190,7 @@ public Object getSnapshot(String objectID, Class<?> objectClass, String commitID
 
 	}
 
-	private CdoSnapshot findCdoSnapshotByCommit(Commit commit) {
+	public CdoSnapshot findCdoSnapshotByCommit(Commit commit) {
 
 		String id = commit.getObjectID();
 		Class<?> clazz = commit.getObjectClass();

corolla-backend/corolla-backend-domain-commons/src/test/groovy/com/tocea/corolla/revisions/services/JaversRevisionServiceTest.groovy

@@ -62,7 +62,7 @@ class JaversRevisionServiceTest extends Specification {
 
 	}
 
-	def "it should compare to version of the same object"() {
+	def "it should compare two versions of the same object"() {
 
 		given:
 			def old = new DomainObject(id: "1")
@@ -78,4 +78,63 @@ class JaversRevisionServiceTest extends Specification {
 
 	}
 
+	def "it should retrieve a commit in the history from its ID"() {
+
+		given:
+			def objectID = "1"
+			def objectClass = DomainObject.class
+			def commitID = "2"
+			def history = [new Commit(id: "3"), new Commit(id: "2"), new Commit(id: "1")]
+
+		and:
+			def JaversRevisionService service = Spy()
+
+		when:
+			def commit = service.findCommitByID(objectID, objectClass, commitID)
+
+		then:			
+			service.getHistory(objectID, objectClass) >> history
+
+		then:
+			commit == history[1]
+			notThrown(Exception.class)
+
+	}
+
+	def "it should return the previous commit from a commit ID"() {
+
+		given:
+			def objectID = "1"
+			def objectClass = DomainObject.class
+			def commitID = "2"
+			def history = [new Commit(id: "3"), new Commit(id: "2"), new Commit(id: "1")]
+
+		and:
+			def JaversRevisionService service = Spy()
+
+		when:
+			def commit = service.getPreviousCommit(objectID, objectClass, commitID)
+
+		then:		
+			service.getHistory(objectID, objectClass) >> history
+
+		then:
+			commit == history[2]
+			notThrown(Exception.class)
+
+	}
+
+	def "it should find a Javers CdoSnapshot instance by commit data"() {
+
+		given:
+			def commit = new Commit(id: "1", objectID: "1", objectClass: DomainObject.class)
+
+		when:
+			revisionService.findCdoSnapshotByCommit(commit)
+
+		then:
+			1 * javers.findSnapshots(_)
+			notThrown(Exception.class)
+	}
+
 }