UnusedVariableSniff: Fixed false positive

slevomat · Mar 16, 2020 · 3c5fc9b · 3c5fc9b
1 parent 8ef56e0
commit 3c5fc9b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/SlevomatCodingStandard/Helpers/VariableHelper.php b/SlevomatCodingStandard/Helpers/VariableHelper.php
@@ -99,7 +99,7 @@ public static function isUsedInScopeInString(File $phpcsFile, string $variableNa
 		}
 
 		$variableNameWithoutDollar = substr($variableName, 1);
-		return preg_match('~\$\{' . preg_quote($variableNameWithoutDollar, '~') . '\}~', $stringContent) !== 0;
+		return preg_match('~\$\{' . preg_quote($variableNameWithoutDollar, '~') . '(<=\}|\b)~', $stringContent) !== 0;
 	}
 
 	private static function isUsedInScopeInternal(

diff --git a/tests/Sniffs/Variables/data/unusedVariableNoErrors.php b/tests/Sniffs/Variables/data/unusedVariableNoErrors.php
@@ -129,6 +129,11 @@ function () {
 	echo "${a}";
 };
 
+function () {
+	$a = '';
+	echo "${a[0]}";
+};
+
 function () {
 	$a = '';
 	echo "$a()";