RequireNumericLiteralSeparatorSniff: New options "minDigitsBeforeDeci…

…malPoint" and "minDigitsAfterDecimalPoint"

README.md

@@ -711,6 +711,8 @@ Requires use of numeric literal separators.
 This sniff provides the following setting:
 
 * `enable`: either to enable or no this sniff. By default, it is enabled for PHP versions 7.4 or higher.
+* `minDigitsBeforeDecimalPoint`: the mininum digits before decimal point to require separator.
+* `minDigitsAfterDecimalPoint`: the mininum digits after decimal point to require separator.
 
 #### SlevomatCodingStandard.PHP.ReferenceSpacing 🔧
 

SlevomatCodingStandard/Sniffs/Numbers/RequireNumericLiteralSeparatorSniff.php

@@ -18,6 +18,12 @@ class RequireNumericLiteralSeparatorSniff implements Sniff
 	/** @var bool|null  */
 	public $enable = null;
 
+	/** @var int */
+	public $minDigitsBeforeDecimalPoint = 4;
+
+	/** @var int */
+	public $minDigitsAfterDecimalPoint = 4;
+
 	/**
 	 * @return array<int, (int|string)>
 	 */
@@ -48,7 +54,8 @@ public function process(File $phpcsFile, $numberPointer): void
 			return;
 		}
 
-		if (preg_match('~(?:^\\d{4}|\.\\d{4})~', $tokens[$numberPointer]['content']) === 0) {
+		$regexp = '~(?:^\\d{' . SniffSettingsHelper::normalizeInteger($this->minDigitsBeforeDecimalPoint) . '}|\.\\d{' . SniffSettingsHelper::normalizeInteger($this->minDigitsAfterDecimalPoint) . '})~';
+		if (preg_match($regexp, $tokens[$numberPointer]['content']) === 0) {
 			return;
 		}
 

tests/Sniffs/Numbers/RequireNumericLiteralSeparatorSniffTest.php

@@ -30,6 +30,30 @@ public function testErrors(): void
 		self::assertSniffError($report, 7, RequireNumericLiteralSeparatorSniff::CODE_REQUIRED_NUMERIC_LITERAL_SEPARATOR);
 	}
 
+	public function testModifiedSettingsNoErrors(): void
+	{
+		$report = self::checkFile(__DIR__ . '/data/requireNumericLiteralSeparatorModifiedSettingsNoErrors.php', [
+			'enable' => true,
+			'minDigitsBeforeDecimalPoint' => 7,
+			'minDigitsAfterDecimalPoint' => 6,
+		]);
+		self::assertNoSniffErrorInFile($report);
+	}
+
+	public function testModifiedSettingsErrors(): void
+	{
+		$report = self::checkFile(__DIR__ . '/data/requireNumericLiteralSeparatorModifiedSettingsErrors.php', [
+			'enable' => true,
+			'minDigitsBeforeDecimalPoint' => 7,
+			'minDigitsAfterDecimalPoint' => 6,
+		]);
+
+		self::assertSame(2, $report->getErrorCount());
+
+		self::assertSniffError($report, 3, RequireNumericLiteralSeparatorSniff::CODE_REQUIRED_NUMERIC_LITERAL_SEPARATOR);
+		self::assertSniffError($report, 4, RequireNumericLiteralSeparatorSniff::CODE_REQUIRED_NUMERIC_LITERAL_SEPARATOR);
+	}
+
 	public function testShouldNotReportIfSniffIsDisabled(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/requireNumericLiteralSeparatorErrors.php', [

tests/Sniffs/Numbers/data/requireNumericLiteralSeparatorModifiedSettingsErrors.php

@@ -0,0 +1,4 @@
+<?php // lint >= 7.4
+
+1000000;
+1.000000;

tests/Sniffs/Numbers/data/requireNumericLiteralSeparatorModifiedSettingsNoErrors.php

@@ -0,0 +1,4 @@
+<?php // lint >= 7.4
+
+100000;
+1.00000;