SlevomatCodingStandard.ControlStructures.DisallowYodaComparison/Requi…

…reYodaComparison: Fixed support for condition in arrow function
slevomat · Sep 21, 2022 · 82a0002 · 82a0002
1 parent 4131db1
commit 82a0002
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/SlevomatCodingStandard/Helpers/YodaHelper.php b/SlevomatCodingStandard/Helpers/YodaHelper.php
@@ -36,6 +36,7 @@
 use const T_DOUBLE_CAST;
 use const T_DOUBLE_COLON;
 use const T_FALSE;
+use const T_FN_ARROW;
 use const T_INLINE_ELSE;
 use const T_INLINE_THEN;
 use const T_INT_CAST;
@@ -346,6 +347,7 @@ private static function getStopTokenCodes(): array
 				T_COMMA => true,
 				T_CLOSE_CURLY_BRACKET => true,
 				T_MATCH_ARROW => true,
+				T_FN_ARROW => true,
 			];
 
 			$stopTokenCodes += array_fill_keys(array_keys(Tokens::$assignmentTokens), true);

diff --git a/tests/Sniffs/ControlStructures/data/disallowYodaComparisonNoErrors.php b/tests/Sniffs/ControlStructures/data/disallowYodaComparisonNoErrors.php
@@ -79,3 +79,7 @@ function ($condition, $actual) {
 		default => false,
 	};
 };
+
+$event = $actualEvents->find(
+	static fn (SpaceflowEvent $event): bool => $expectedEvent::class === $event::class,
+);
diff --git a/tests/Sniffs/ControlStructures/data/requireYodaComparisonNoErrors.php b/tests/Sniffs/ControlStructures/data/requireYodaComparisonNoErrors.php
@@ -80,3 +80,7 @@ function ($condition, $actual) {
 		default => false,
 	};
 };
+
+$event = $actualEvents->find(
+	static fn (SpaceflowEvent $event): bool => $expectedEvent::class === $event::class,
+);