RequireArrowFunctionSniff requires PHP 7.4

Fix #924
slevomat · Mar 22, 2020 · e27ab09 · e27ab09
1 parent 81ad6e7
commit e27ab09
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -600,6 +600,7 @@ Requires arrow functions.
 Sniff provides the following settings:
 
 * `allowNested` (defaults to `true`)
+* `enable`: either to enable or no this sniff. By default, it is enabled for PHP versions 7.4 or higher.
 
 #### SlevomatCodingStandard.Functions.TrailingCommaInCall 🔧
 

diff --git a/SlevomatCodingStandard/Sniffs/Functions/RequireArrowFunctionSniff.php b/SlevomatCodingStandard/Sniffs/Functions/RequireArrowFunctionSniff.php
@@ -5,6 +5,7 @@
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Sniffs\Sniff;
 use SlevomatCodingStandard\Helpers\ScopeHelper;
+use SlevomatCodingStandard\Helpers\SniffSettingsHelper;
 use SlevomatCodingStandard\Helpers\TokenHelper;
 use function count;
 use const T_BITWISE_AND;
@@ -24,6 +25,9 @@ class RequireArrowFunctionSniff implements Sniff
 	/** @var bool */
 	public $allowNested = true;
 
+	/** @var bool|null  */
+	public $enable = null;
+
 	/**
 	 * @return array<int, (int|string)>
 	 */
@@ -41,6 +45,12 @@ public function register(): array
 	 */
 	public function process(File $phpcsFile, $closurePointer): void
 	{
+		$this->enable = SniffSettingsHelper::isEnabledByPhpVersion($this->enable, 70400);
+
+		if (!$this->enable) {
+			return;
+		}
+
 		$tokens = $phpcsFile->getTokens();
 
 		$returnPointer = TokenHelper::findNextEffective($phpcsFile, $tokens[$closurePointer]['scope_opener'] + 1);

diff --git a/tests/Sniffs/Functions/RequireArrowFunctionSniffTest.php b/tests/Sniffs/Functions/RequireArrowFunctionSniffTest.php
@@ -11,6 +11,7 @@ public function testDisallowNestedNoErrors(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/requireArrowFunctionDisallowNestedNoErrors.php', [
 			'allowNested' => false,
+			'enable' => true,
 		]);
 		self::assertNoSniffErrorInFile($report);
 	}
@@ -19,6 +20,7 @@ public function testDisallowNestedErrors(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/requireArrowFunctionDisallowNestedErrors.php', [
 			'allowNested' => false,
+			'enable' => true,
 		]);
 
 		self::assertSame(4, $report->getErrorCount());
@@ -35,6 +37,7 @@ public function testAllowNestedNoErrors(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/requireArrowFunctionAllowNestedNoErrors.php', [
 			'allowNested' => true,
+			'enable' => true,
 		]);
 		self::assertNoSniffErrorInFile($report);
 	}
@@ -43,6 +46,7 @@ public function testAllowNestedErrors(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/requireArrowFunctionAllowNestedErrors.php', [
 			'allowNested' => true,
+			'enable' => true,
 		]);
 
 		self::assertSame(3, $report->getErrorCount());
@@ -54,4 +58,15 @@ public function testAllowNestedErrors(): void
 		self::assertAllFixedInFile($report);
 	}
 
+	public function testShouldNotReportIfSniffIsDisabled(): void
+	{
+		$report = self::checkFile(__DIR__ . '/data/requireArrowFunctionAllowNestedErrors.php', [
+			'allowNested' => true,
+			'enable' => false,
+		]);
+
+		self::assertSame(0, $report->getErrorCount());
+		self::assertNoSniffErrorInFile($report);
+	}
+
 }