Docblock of parent abstract method is being ignored

[boesing]

Hey there,

I have the following unit test structure:

<?php

namespace LaminasTest\Cache\Pattern;

use Laminas\Cache\PatternPluginManager;
use Laminas\ServiceManager\ServiceManager;
use PHPUnit\Framework\TestCase;

abstract class AbstractCommonPatternTest extends TestCase
{
    /**
     * A data provider for common pattern names
     *
     * @return iterable<string,array{0:string}>
     */
    abstract public function getCommonPatternNamesProvider();

    /**
     * @dataProvider getCommonPatternNamesProvider
     */
    public function testPatternPluginManagerWithCommonNames(string $commonPatternName)
    {
        $pluginManager = new PatternPluginManager(new ServiceManager());
        self::assertTrue(
            $pluginManager->has($commonPatternName),
            "Pattern name '{$commonPatternName}' not found in PatternPluginManager"
        );
    }
}

When extending this abstract class and implementing the data provider like this, I get SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingAnyTypeHint:

<?php

class CallbackCacheTestAbstract extends AbstractCommonPatternTest
{
    public function getCommonPatternNamesProvider()
    {
        return [
            'lowercase' => ['callback'],
            'lcfirst'   => ['Callback'],
        ];
    }
}

---

It looks like the codestandard is not parsing the parent classes for docblocks. Is that intended?

[kukulich]

@boesing yes, it’s intended becase PHPCS works in one-file scope.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.