SingleLineArrayWhitespaceSniff: Fix spacing around brackets #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukulich
requested changes
Jan 23, 2020
SlevomatCodingStandard/Sniffs/Arrays/SingleLineArrayWhitespaceSniff.php
Outdated
Show resolved
Hide resolved
SlevomatCodingStandard/Sniffs/Arrays/SingleLineArrayWhitespaceSniff.php
Outdated
Show resolved
Hide resolved
SlevomatCodingStandard/Sniffs/Arrays/SingleLineArrayWhitespaceSniff.php
Outdated
Show resolved
Hide resolved
tests/Sniffs/Arrays/data/singleLineArrayWhitespaceErrors.fixed.php
Outdated
Show resolved
Hide resolved
SlevomatCodingStandard/Sniffs/Arrays/SingleLineArrayWhitespaceSniff.php
Outdated
Show resolved
Hide resolved
kukulich
reviewed
Jan 23, 2020
SlevomatCodingStandard/Sniffs/Arrays/SingleLineArrayWhitespaceSniff.php
Outdated
Show resolved
Hide resolved
|
Thanks for your review. I apologize for the CI failures, Phing is not running correctly on my machine. I've had to edit the paths of various files in the |
|
@mcaskill If you can squash the fix commits to the first two then I can merge it from my mobile phone :) |
Normalize `$spacesAroundBrackets` as integer from new method `getSpacesAroundBrackets()`.
Replicated "Squiz.Arrays.ArrayDeclaration.SpaceInEmptyArray" to ensure empty array declaration must have no space between the brackets. This also prevents any required spaces around array brackets to ignore empty array declarations.
kukulich
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spacesAroundBracketsfrom XML; normalizes property value to integer.SpaceInEmptyArraysniff to collapse any whitespace in an empty array declaration.