Fix non-detected private typed properties in PHP 7.4 #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukulich
requested changes
Jan 28, 2020
build.xml
Outdated
| @@ -22,15 +22,33 @@ | |||
| </target> | |||
|
|
|||
| <target name="lint"> | |||
| <exec | |||
There was a problem hiding this comment.
This is useless, please remove.
| @@ -231,4 +232,18 @@ public function testClassWithWriteOnlyProperties(): void | |||
| } | |||
| } | |||
|
|
|||
| public function testClassWithTypedProperties(): void | |||
| { | |||
| if (PHP_VERSION_ID < 70400) { | |||
There was a problem hiding this comment.
All tests should work on all versions, please remove.
| class ClassWithTypedProperties | ||
| { | ||
|
|
||
| private self $self; |
There was a problem hiding this comment.
It looks there is indetation with spaces, please change to tabs.
| @@ -0,0 +1,24 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Change to <?php // lint >= 7.4
paxal
commented
Jan 28, 2020
paxal
force-pushed
the
unused-private-php74
branch
from
4d14fb3
to
3f9fae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private typed properties are not detected, thus sniffs likes WriteOnly do not detect them.
I had to handle php7.4 vs php7.3 in the build script to exclude php7.4 specific files from
linttarget.