NameSpaceHelper: introduce namespace cache to speedup namespace lookups #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukulich
requested changes
Mar 25, 2020
| return TokenHelper::findNextAll($phpcsFile, T_NAMESPACE, 0); | ||
| static $cache = []; | ||
|
|
||
| $cacheKey = $phpcsFile->getFilename() . $phpcsFile->getFixedCount(); |
There was a problem hiding this comment.
Please see https://github.com/slevomat/coding-standard/blob/master/SlevomatCodingStandard/Helpers/UseStatementHelper.php#L123 and implement it likewise.
There was a problem hiding this comment.
I moved this logic to SniffLocalCache helper, what do you think about it?
kukulich
requested changes
Mar 25, 2020
nightlinus
force-pushed
the
master
branch
2 times, most recently
from
2bc79a5
to
3d0441a
Compare
|
@nightlinus One last change please. Squash it to one commit or move this change 3d0441a#diff-054ee9cafd168683808f20c4b5d722f1R84 to the right commit. |
|
rebased and squashed |
kukulich
approved these changes
Mar 25, 2020
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduce cache for namespace lookups.
This speed up for 8kloc test-case
Can this cache cause any unwanted side effects?