UnusedVariableSniff: add scope lookup cache to improve performance #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expect the same problem as in other PR - not 100 % code coverage. |
nightlinus
force-pushed
the
perf/UnusedVariable
branch
from
21c41c2
to
ca3d601
Compare
nightlinus
commented
Mar 25, 2020
| } | ||
| } | ||
|
|
||
| return 0; // @codeCoverageIgnore because there is at least one root always |
There was a problem hiding this comment.
added this line to ignore because otherwise phpstan checks not green
nightlinus
force-pushed
the
perf/UnusedVariable
branch
from
ca3d601
to
dd5862e
Compare
|
Should work now, local coverage 100%, done for now, all sniffs are under 0.7s for my ugly 8kloc file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase performance of UnusedVariableSniff by introducing scope lookup cache in ScopeHelper.
For 8kloc test file time dropped from 9s to 0.6s