Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose "no" on "auto-start" print for Octoprint always start the print #3655

Closed
gege2b opened this issue Jan 5, 2017 · 7 comments
Closed

Comments

@gege2b
Copy link
Contributor

gege2b commented Jan 5, 2017

hi all and happy new year :)

Version

Version of Slic3r used goes here
Current dev ( 586d95b )

Operating system type + version

Kubuntu 16.60 x64

Behavior

  • Describe the problem
    Sending Gcode to Octoprint, when prompted if the print should start as soon as the file is uploaded, I choose "no" but the print start anyway. It also start if I choose yes (as expected).

So basically, the print always start, no matter what I choose when prompted

  • Steps needed to reproduce the problem

Load a model, slice it, send to printer, click 'no' for auto-start the print, look the print begin

Another question related to this new octoprint stuff : is there a way to disable this (prompting for the filename AND for autostart) ?

@gege2b
Copy link
Contributor Author

gege2b commented Jan 6, 2017

I have the exact same problem with the current prebuilt binary available on @lordofhyphens 's bintray page on win10 x64

@eloebl
Copy link

eloebl commented Jan 8, 2017

Same problem here too on Linux.

I also wouldn't mind an option to disable that prompt to ask about auto starting.

@gege2b
Copy link
Contributor Author

gege2b commented Jan 8, 2017

OK at least, I'm not the only one who got this issue :)
For the option, I suggested something in #3657

@eloebl
Copy link

eloebl commented Jan 8, 2017

@gege2b Nope :) Meant to log this last week when I hit the issue, but forgot... remembered today, and saw you beat me to it.

@gege2b
Copy link
Contributor Author

gege2b commented Jan 8, 2017

aha :)

after digging a bit into the code, I think I got the culprit
Plater.pm line 1402 :

print => $self->{send_gcode_file} ? 1 : 0,

should be :

print => $self->{send_gcode_file_print} ? 1 : 0,

Still not tested, my octoprint server is not reachable right now, will test tomorrow

gege2b added a commit to gege2b/Slic3r that referenced this issue Jan 8, 2017
@gege2b
Copy link
Contributor Author

gege2b commented Jan 9, 2017

OK I can confirm (tested right now)
@alexrj or @lordofhyphens do you want me to do a PR for this tiny fix ?

@lordofhyphens
Copy link
Member

lordofhyphens commented Jan 9, 2017 via email

alranel added a commit that referenced this issue Jan 11, 2017
Fix for #3655 - always print after gcode send
@alranel alranel closed this as completed Mar 18, 2017
alranel added a commit that referenced this issue Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants