Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for UR (parsed as java.net.URI), OL and UC #14

Merged
merged 1 commit into from Aug 15, 2018

Conversation

KarlSjostrand
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 110

  • 12 of 23 (52.17%) changed or added relevant lines in 3 files are covered.
  • 11 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.6%) to 91.672%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/scala/se/nimsa/dicom/data/Value.scala 5 16 31.25%
Files with Coverage Reduction New Missed Lines %
src/main/scala/se/nimsa/dicom/streams/ElementFlows.scala 1 89.58%
src/main/scala/se/nimsa/dicom/data/DicomParts.scala 1 75.0%
src/main/scala/se/nimsa/dicom/data/Elements.scala 1 93.21%
src/main/scala/se/nimsa/dicom/streams/ParseFlow.scala 1 98.47%
src/main/scala/se/nimsa/dicom/streams/CollectFlow.scala 1 87.5%
src/main/scala/se/nimsa/dicom/data/Value.scala 2 85.47%
src/main/scala/se/nimsa/dicom/streams/ValidateFlow.scala 2 91.3%
src/main/scala/se/nimsa/dicom/streams/DicomFlows.scala 2 90.61%
Totals Coverage Status
Change from base Build 109: -0.6%
Covered Lines: 1442
Relevant Lines: 1573

💛 - Coveralls

Copy link
Contributor

@fredrik-exini fredrik-exini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredrik-exini fredrik-exini merged commit e263249 into develop Aug 15, 2018
@KarlSjostrand KarlSjostrand deleted the bugfix/#12-missing-vrs branch August 15, 2018 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants