Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated parsing with inflating and flows with deflating of DICOM data… #30

Merged
merged 1 commit into from Jan 10, 2019
Merged

Updated parsing with inflating and flows with deflating of DICOM data… #30

merged 1 commit into from Jan 10, 2019

Conversation

KarlSjostrand
Copy link
Contributor

… to use Akka streams graphs instead of Javas synchronoous API

@KarlSjostrand
Updated parsing with inflating and flows with deflating of DICOM data…
eaa065d 
… to use Akka streams graphs instead of Javas synchronoous API
@coveralls
Copy link

Pull Request Test Coverage Report for Build 179

  • 80 of 86 (93.02%) changed or added relevant lines in 3 files are covered.
  • 11 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.3%) to 91.006%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/scala/se/nimsa/dicom/streams/ByteStringParser.scala 6 7 85.71%
src/main/scala/se/nimsa/dicom/streams/ParseFlow.scala 56 61 91.8%
Files with Coverage Reduction New Missed Lines %
src/main/scala/se/nimsa/dicom/streams/ModifyFlow.scala 1 97.06%
src/main/scala/se/nimsa/dicom/streams/CollectFlow.scala 1 89.58%
src/main/scala/se/nimsa/dicom/streams/ValidateFlow.scala 1 92.39%
src/main/scala/se/nimsa/dicom/streams/ByteStringParser.scala 2 81.48%
src/main/scala/se/nimsa/dicom/streams/DicomFlows.scala 3 89.7%
src/main/scala/se/nimsa/dicom/data/DicomParts.scala 3 70.83%
Totals Coverage Status
Change from base Build 177: -0.3%
Covered Lines: 1538
Relevant Lines: 1690
💛 - Coveralls

fredrik-exini
fredrik-exini approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@fredrik-exini fredrik-exini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KarlSjostrand KarlSjostrand merged commit 6d91016 into develop Jan 10, 2019
@KarlSjostrand KarlSjostrand deleted the feature/streaming-compression branch January 10, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrik-exini fredrik-exini fredrik-exini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KarlSjostrand @coveralls @fredrik-exini