Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dicom attributes #6

Merged
merged 58 commits into from
Jul 12, 2018
Merged

Feature/dicom attributes #6

merged 58 commits into from
Jul 12, 2018

Conversation

KarlSjostrand
Copy link
Contributor

  • Refactored attributes -> elements
  • Refactored some class names, skipping the "Dicom" prefix for brevity
  • Created Element class for describing a single DICOM data element, with parsing to various formats of its value
  • Created Elements class for aggregating and working with sets of Element instances
  • Created ElementFolds class for streaming aggregation into Elements
  • Created the managed source 'Keyword' file for tag-to-tagname lookups
  • Added more tags to Tag, Dictionary and Keyword files from DICOM part 6 and 7
  • Updated TagPath less-than operator along with ModifyFlow to work more stringently
  • Added tests and documentation

@coveralls
Copy link

coveralls commented Apr 24, 2018

Pull Request Test Coverage Report for Build 84

  • 937 of 1017 (92.13%) changed or added relevant lines in 18 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.8%) to 91.747%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/scala/se/nimsa/dicom/data/CharacterSets.scala 5 6 83.33%
src/main/scala/se/nimsa/dicom/streams/ModifyFlow.scala 21 22 95.45%
src/main/scala/se/nimsa/dicom/data/package.scala 83 84 98.81%
src/main/scala/se/nimsa/dicom/streams/ParseFlow.scala 23 25 92.0%
src/main/scala/se/nimsa/dicom/streams/DicomFlows.scala 56 59 94.92%
src/main/scala/se/nimsa/dicom/streams/ElementFlows.scala 43 48 89.58%
src/main/scala/se/nimsa/dicom/data/DicomParts.scala 19 24 79.17%
src/main/scala/se/nimsa/dicom/streams/CollectFlow.scala 43 48 89.58%
src/main/scala/se/nimsa/dicom/streams/DicomFlow.scala 54 64 84.38%
src/main/scala/se/nimsa/dicom/data/DicomParsing.scala 107 117 91.45%
Files with Coverage Reduction New Missed Lines %
src/main/scala/se/nimsa/dicom/streams/DicomFlow.scala 1 87.21%
src/main/scala/se/nimsa/dicom/streams/DicomFlows.scala 2 90.61%
Totals Coverage Status
Change from base Build 17: 1.8%
Covered Lines: 1434
Relevant Lines: 1563

💛 - Coveralls

…ments delimitation. Replaced with new stateful flow trait InFragments
Copy link
Contributor

@fredrik-exini fredrik-exini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@fredrik-exini fredrik-exini merged commit 653675f into develop Jul 12, 2018
@KarlSjostrand KarlSjostrand deleted the feature/dicom-attributes branch July 30, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants