ENH: Update project name in CMake #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thewtex Could you please take a look at this PR as a sanity check? This is a small PR so that ITKShape will build as an ITK remote module under the name "ITKShape" rather than "ITKMesh3DProcrustesAlignFilter". |
Hi @allemangD I did not know Jared was working on it. Please disregard. |
|
Thanks @bpaniagua, whoever wants to review is fine, just trying to get another set of eyes on it before we add ITKShape as an ITK remote module. |
vicory
reviewed
Aug 30, 2021
tbirdso
commented
Aug 30, 2021
dzenanz
reviewed
Sep 13, 2021
tbirdso
force-pushed
the
rename-project
branch
from
dc37c7d
to
09021b0
Compare
tbirdso
commented
Sep 13, 2021
tbirdso
commented
Sep 13, 2021
dzenanz
approved these changes
Sep 14, 2021
tbirdso
force-pushed
the
rename-project
branch
from
09021b0
to
d887164
Compare
|
Fixed formatting with |
dzenanz
approved these changes
Sep 14, 2021
|
Going to go ahead and merge this as all tests passed prior to style fix. Thanks for reviewing @dzenanz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project repository was renamed from
Mesh3DProcrustesAlignTesttoITKShapeshortly after creation, but CMake build generation continued to use the previous name. This PR fixes the project name in CMake in preparation for adding to ITK as a remote module per Issue 22.