-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Database Config somewhere that isn't in the scaladoc #1669
Comments
@joearasin do you have a suggestion where to best mention it in the docs. A PR would be ideal, Slick is free software and relies on all of our contributions to be better :). |
or, rather, here: http://slick.lightbend.com/doc/3.1.1/database.html -- There's the parenthetical "(see the API documentation of this method for details on the configuration parameters)", but clicking on it doesn't bring you to something that is obviously useful. |
so there is this section: http://slick.lightbend.com/doc/3.1.1/gettingstarted.html#database-configuration What are you missing? |
And what part of the scaladoc are you referring to? |
Now that I think about it, the potentially trivial-to-implement thing that would be useful (and I don't know if it's possible) is having the link to the scaladoc automatically open the collapsed "forConfig" |
we can link to it like this
won't open but highlight |
I think the issue I really want to file is on Scaladoc itself, allowing permalinks to open entries. |
cc @felixmulder |
Hmm, should probably open - but not sure on the current URL scheme. As long as it is a field or method it should expand. Look at something like the stdlib and the linking done between methods or top-level packages? |
Also, chrome is the most tested browser afaicr |
The link posted by @cvogt is the old scheme - will have a look when I'm not on mobile |
Sorry for the late response (my mac has risen from the dead, huzzah! 🎉), the new scheme looks like this:
This will open
Beware that since the scheme has changed from 2.11, there we're sort of in a bind when it comes to cross-published libraries. If you feel that this is an annoyance - please make a PR to scala/scala fixing this, and everyone will 👍 ❤️ |
@felixmulder are old links no longer working with the new scaladoc? |
The new scaladoc has a different layout for the static site. The old one had a single index file and used iframes to load all content. This destroys the browser's caching and worked poorly on mobile devices. So, we decided to use a different layout. IIRC, new links work with the old layout but not vv. This is due to the old one redirecting to the root index and applying the path given. There's a caveat with this where package objects don't accept these links. I think there's an issue open for it. |
I see. All in agreement with your changes providing a better user experience for Scaladoc. I am worried about old links no longer working as it will break documentation sites and is quite hard to identify until somebody tries the link. I know Slick's documentation makes heavy use of the old links. Not sure what other libs do, too. Doing an automatic translation for the old links shouldn't be too hard.
|
The usability of burying the database config documentation in a collapsed field of Scaladoc is not good. "How do I configure this thing?" is one of the first questions users will have re: slick, and it's not particularly discoverable that what is effectively the manual is buried in a collapsed Scaladoc entry (which typically tends more towards discussion of implementation details than vital information).
The text was updated successfully, but these errors were encountered: