-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation fails on Scala 2.13.11-M1 due to new -Xsource:3
change
#2673
Comments
-Xsource:3
change-Xsource:3
change
-Xsource:3
change-Xsource:3
change
Are you on 3.5.0-M2? That has no warnings with 2.13.10 -Xsource:3. I saw such errors while I was rebasing But I'm not clear the point of this issue. If minor scala releases shouldn't break code that uses -Xsource:3 then it violates that either way, and if they can then what's the issue? If the point is just to have a ticket to close when that is fixed in Slick, then sure ok thanks ;) |
I'm on c4cb91a, current HEAD of main branch
There's no need for a release. The community build builds things from source, so as soon as a fix has been pushed here, I'll be able to pull it in.
Well, that, yes, it's a heads up as a courtesy to the project. But also, I'm inviting you to let us know if you think that the errors are spurious, since it's possible (hopefully not too likely) that the change we made was somehow erroneous. |
Probably not spurious since scala 3 itself gave a number of such errors, and the way slick is architected such collisions are probably likely. But I could be more sure if you tell me the approximate number of such errors or I could see them (I can build on M1 on Sunday hopefully). |
Jinx, I have the same result from local compile. |
Lukas was working at reducing warnings for term aliases.
Here, params to |
Yeah, this is really the canonical example where the new warning is annoying...
I tried but didn't find a viable solution scala/scala#10220 (comment) |
not actually sure if these changes are correct, but in case it's useful: scalacommunitybuild/slick@4ec74bf |
@nafg curious how this ended up being resolved, if at all |
It was fixed in 7d653e8 |
this came up in the Scala 2 community build
when I compile Slick with 2.13.11-M1, because you use
-Xsource:3
I get compilation errors such as:there are a bunch more in the same vein
it appears to me, offhand, that these errors are expected consequences of scala/scala#10220 , but if you believe otherwise, please let us know
cc @lrytz @som-snytt
The text was updated successfully, but these errors were encountered: