ClassCastException caused by empty inSet on Option column

[ijuma]

This is a regression in Slick 2.1.0-M1.

Here's a commit that updates a test to include the failing case:

https://github.com/ijuma/slick/commit/911ca04468959278457bd544cbb40e4eee742bd0

The stacktrace:

java.lang.Boolean cannot be cast to scala.Option
java.lang.ClassCastException: java.lang.Boolean cannot be cast to scala.Option
    at scala.slick.driver.JdbcStatementBuilderComponent$class.valueToSQLLiteral(JdbcStatementBuilderComponent.scala:36)
    at scala.slick.driver.H2Driver$.valueToSQLLiteral(H2Driver.scala:62)
    at scala.slick.driver.JdbcStatementBuilderComponent$QueryBuilder.expr(JdbcStatementBuilderComponent.scala:205)
    at scala.slick.driver.H2Driver$QueryBuilder.scala$slick$driver$JdbcStatementBuilderComponent$OracleStyleRowNum$$super$expr(H2Driver.scala:44)
    at scala.slick.driver.JdbcStatementBuilderComponent$OracleStyleRowNum$class.expr(JdbcStatementBuilderComponent.scala:436)
    at scala.slick.driver.H2Driver$QueryBuilder.expr(H2Driver.scala:50)
    at scala.slick.driver.JdbcStatementBuilderComponent$QueryBuilder$$anonfun$buildWhereClause$1.apply$mcV$sp(JdbcStatementBuilderComponent.scala:136)
    at scala.slick.driver.JdbcStatementBuilderComponent$QueryBuilder.building(JdbcStatementBuilderComponent.scala:71)
    at scala.slick.driver.JdbcStatementBuilderComponent$QueryBuilder.buildWhereClause(JdbcStatementBuilderComponent.scala:133)
    at scala.slick.driver.JdbcStatementBuilderComponent$QueryBuilder.buildComprehension(JdbcStatementBuilderComponent.scala:92)
    at scala.slick.driver.JdbcStatementBuilderComponent$QueryBuilder.buildSelect(JdbcStatementBuilderComponent.scala:62)
    at scala.slick.driver.JdbcProfile$$anonfun$queryCompiler$1.apply(JdbcProfile.scala:30)
    at scala.slick.driver.JdbcProfile$$anonfun$queryCompiler$1.apply(JdbcProfile.scala:30)
    at scala.slick.jdbc.JdbcMappingCompilerComponent$JdbcCodeGen$$anonfun$apply$2.apply(JdbcMappingCompilerComponent.scala:64)
    at scala.slick.jdbc.JdbcMappingCompilerComponent$JdbcCodeGen$$anonfun$apply$2.apply(JdbcMappingCompilerComponent.scala:63)
    at scala.slick.ast.ClientSideOp$.mapResultSetMapping(ClientSideOp.scala:22)
    at scala.slick.jdbc.JdbcMappingCompilerComponent$JdbcCodeGen.apply(JdbcMappingCompilerComponent.scala:63)
    at scala.slick.jdbc.JdbcMappingCompilerComponent$JdbcCodeGen$$anonfun$apply$1.apply(JdbcMappingCompilerComponent.scala:60)
    at scala.slick.jdbc.JdbcMappingCompilerComponent$JdbcCodeGen$$anonfun$apply$1.apply(JdbcMappingCompilerComponent.scala:60)
    at scala.slick.compiler.CompilerState.map(QueryCompiler.scala:176)
    at scala.slick.jdbc.JdbcMappingCompilerComponent$JdbcCodeGen.apply(JdbcMappingCompilerComponent.scala:60)
    at scala.slick.compiler.QueryCompiler$$anonfun$runPhase$1.apply(QueryCompiler.scala:79)
    at scala.slick.compiler.QueryCompiler$$anonfun$runPhase$1.apply(QueryCompiler.scala:78)
    at scala.util.DynamicVariable.withValue(DynamicVariable.scala:57)
    at scala.slick.ast.SymbolNamer.use(Symbol.scala:92)
    at scala.slick.compiler.QueryCompiler.runPhase(QueryCompiler.scala:78)
    at scala.slick.compiler.QueryCompiler$$anonfun$runPhases$4.apply(QueryCompiler.scala:75)
    at scala.slick.compiler.QueryCompiler$$anonfun$runPhases$4.apply(QueryCompiler.scala:75)
    at scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:144)
    at scala.collection.TraversableOnce$$anonfun$foldLeft$1.apply(TraversableOnce.scala:144)
    at scala.collection.Iterator$class.foreach(Iterator.scala:727)
    at scala.collection.AbstractIterator.foreach(Iterator.scala:1157)
    at scala.collection.TraversableOnce$class.foldLeft(TraversableOnce.scala:144)
    at scala.collection.AbstractIterator.foldLeft(Iterator.scala:1157)
    at scala.slick.compiler.QueryCompiler.runPhases(QueryCompiler.scala:75)
    at scala.slick.compiler.QueryCompiler.run(QueryCompiler.scala:53)
    at scala.slick.compiler.QueryCompiler.run(QueryCompiler.scala:47)
    at scala.slick.profile.BasicProfile$Implicits$class.queryToQueryExecutor(BasicProfile.scala:51)

[cvogt]

here is the test from @ijuma's commit:

users.filter(_.last inSetBind Seq()).map(u => (u.first, u.last)).run

added to the end of MainTest

[szeiger]

Looks unrelated to the recent changes with Option handling moving from JdbcType into ResultConverter. It's actually a bug in the hoistClientOps phase. This needs to be double-checked against 2.0.0 and 2.0.1 to make sure the bug is not there (I would expect it to be). Working on a fix for 2.1.

[ijuma]

Our test passes with Slick 2.0.1 and fails with 2.1.0-M1. So something changed that caused this to be triggered.

[szeiger]

The bug in hoistClientOps is the same in 2.0 but it's cancelled out by another bug: https://github.com/slick/slick/blob/2.0/src/main/scala/scala/slick/driver/JdbcStatementBuilderComponent.scala#L192 - Notice that this looks at tpe (the special statically known type of a TypedNode), not nodeType (the dynamically computed type), so it still sees the original (correct) type and not the wrong one produced by hoistClientOps.

[ijuma]

Got to love bugs that cancel other bugs. :)