Expose AsyncExecutor workload to monitoring via JMX #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Parse `registerMbeans` and `poolName` options in `JdbcBackend` and document that they apply to all pool implementations, not just HikariCP. The AsyncExecutor is now created with the configured `poolName` (instead of the config path) as its name. - Register an implementation of the new `AsyncExecutorMXBean` interface as an MBean when creating an `AsyncExecutor` with `registerMbeans=true`. It is unregistered on `close()`. Any errors during registration or unregistration are logged as errors and ignored. Fixes #1532. Test in MBeansTest.testMBeans.
|
Updated test case to accept queue size 4 as well. After @kwark's comments on #1274 I assumed that a |
|
Any takers? |
|
@cvogt Can you take a look? |
|
Since I can't get anyone to take I look I'll assume there are no objections. |
|
Missed the notification for this. Skimmed the code now. Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registerMbeansandpoolNameoptions inJdbcBackendanddocument that they apply to all pool implementations, not just
HikariCP. The AsyncExecutor is now created with the configured
poolName(instead of the config path) as its name.AsyncExecutorMXBeaninterfaceas an MBean when creating an
AsyncExecutorwithregisterMbeans=true.It is unregistered on
close(). Any errors during registration orunregistration are logged as errors and ignored.
Fixes #1532. Test in MBeansTest.testMBeans.