Fixing #966 #1555
Merged
Fixing #966 #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| protected lazy val (pkSyms, softSyms) = syms.toSeq.partition(_.options.contains(ColumnOption.PrimaryKey)) | ||
| /* NOTE: pk defined by using method `primaryKey` and pk defined with `PrimaryKey` can only have one, | ||
| here we let table ddl to help us ensure this. */ | ||
| private lazy val funcDefinedPKs = table.profileTable.asInstanceOf[Table[_]].primaryKeys |
There was a problem hiding this comment.
why is asInstanceOf[Table[_]] needed?
There was a problem hiding this comment.
Because table.profileTable was declared as Any.
|
Apart from the comment I like it :). Great work. |
|
I'm curious on the status of this. I was going to try it out with my codebase, but since it's based on 3.2 and won't trivially backport to 3.1 I'm bailing out of that. Is the remaining issue the derby issue? |
|
Curious about the state of this as well. We used this patch / fork to get around the insertOrUpdate bug. If it's not an issue anymore would love to not need to special-case this. |
|
@cvogt I'd like to merge it in. |
|
LGTM. Go ahead, merge :). |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is trying to fix #966 by including
Table.primary(..)defined primary keys when generating upsert sql.It's not perfect. As the comment said, it remained a derby related issue.
Pls review and give your suggestions.
Thanks!