Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed packageContainerCode method #2069

Closed
wants to merge 1 commit into from

Conversation

mrForest13
Copy link

Hello,

there is an error in packageContainerCode method, let's consider examples:

  1. For not empty parentType and codePerTable
def parentType: Option[String] = Some("Example")
def codePerTable: Map[String, String] = Map("Example1" -> "Example1", "Example2" -> "Example2")

it's generate

trait Tables extends Example extends Example1 with Example2
  1. For empty parentType and codePerTable
trait Tables extends

@lightbend-cla-validator
Copy link
Collaborator

Hi @mrForest13,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@mrForest13
Copy link
Author

I have just signed the CLA :)

@SethTisue
Copy link
Member

is this still relevant? is somebody able to review it?

@SethTisue
Copy link
Member

It isn't obvious to me how the merge conflict should be resolved. @mrForest13 can you rebase this?

Base automatically changed from master to main March 19, 2021 19:42
@nafg
Copy link
Member

nafg commented Apr 14, 2021

I believe this is fixed by #2149 -- if I'm missing something let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants