Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach base statement as child for asTry dumpInfo #2584

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

natefitzgerald
Copy link

The getDumpInfo method of asTry should have the action that is to be tried as a child for logging purposes.

This is my first contribution here, sorry if there's a template I need to be following or something. I created this issue for the problem and this single line is all that's needed for the solution. I am happy to add tests if reviewers think it appropriate but I followed exactly the convention established in CleanUpAction

@lightbend-cla-validator
Copy link
Collaborator

@natefitzgerald
Copy link
Author

I have signed the CLA

@nafg
Copy link
Member

nafg commented Oct 20, 2022

Thanks!

See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

If want to change the email address used in the commit, you may need to do something like this:

git config --local user.email XXXXX && git commit --amend --no-edit --reset-author

where XXXXX is an email associated with your github account, and then force-push the branch.

If you want to avoid exposing your email address read https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address.

@github-actions
Copy link
Contributor

There are no incompatible changes

@nafg nafg self-requested a review October 20, 2022 19:17
@github-actions
Copy link
Contributor

There are no incompatible changes

@nafg nafg added this to the 3.5.0 milestone Oct 21, 2022
@nafg
Copy link
Member

nafg commented Oct 21, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2022

refresh

✅ Pull request refreshed

@github-actions
Copy link
Contributor

There are no incompatible changes

@mergify mergify bot merged commit 6f8079f into slick:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asTry should have the original action attached as a child in getDumpInfo
3 participants