Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasicBackend#DatabaseDef#releaseSession: null out the session first, … #2620

Merged
merged 3 commits into from
Jan 11, 2023
Merged

BasicBackend#DatabaseDef#releaseSession: null out the session first, … #2620

merged 3 commits into from
Jan 11, 2023

Conversation

nafg
Copy link
Member

@nafg nafg commented Dec 11, 2022

…in case closing it throws

@nafg nafg mentioned this pull request Dec 11, 2022
Closed
@github-actions
Copy link
Contributor

There are no incompatible changes

@github-actions
Copy link
Contributor

There are no incompatible changes

@nafg nafg force-pushed the issue-2430 branch 2 times, most recently from da142c2 to 82184e6 Compare December 18, 2022 03:22
@slick slick deleted a comment from github-actions bot Dec 18, 2022
@slick slick deleted a comment from github-actions bot Dec 18, 2022
@slick slick deleted a comment from github-actions bot Dec 18, 2022
@github-actions
Copy link
Contributor

Incompatible changes

3 changes to com.typesafe.slick:slick since 3.5.0-pre.158.9b20153a

Code changes

Incompatibility Symbol Problem
Backward slick.jdbc.JdbcBackend#DatabaseDef.releaseSession IncompatibleMethTypeProblem

method releaseSession(slick.basic.BasicBackend#BasicActionContext,Boolean)Unit in class slick.jdbc.JdbcBackend#DatabaseDef's type is different in current version, where it is (slick.basic.BasicBackend#BasicActionContext,scala.PartialFunction)Unit instead of (slick.basic.BasicBackend#BasicActionContext,Boolean)Unit
Backward slick.memory.DistributedBackend#DatabaseDef.releaseSession IncompatibleMethTypeProblem

method releaseSession(slick.basic.BasicBackend#BasicActionContext,Boolean)Unit in class slick.memory.DistributedBackend#DatabaseDef's type is different in current version, where it is (slick.basic.BasicBackend#BasicActionContext,scala.PartialFunction)Unit instead of (slick.basic.BasicBackend#BasicActionContext,Boolean)Unit
Backward slick.memory.HeapBackend#DatabaseDef.releaseSession IncompatibleMethTypeProblem

method releaseSession(slick.basic.BasicBackend#BasicActionContext,Boolean)Unit in class slick.memory.HeapBackend#DatabaseDef's type is different in current version, where it is (slick.basic.BasicBackend#BasicActionContext,scala.PartialFunction)Unit instead of (slick.basic.BasicBackend#BasicActionContext,Boolean)Unit

@slick slick deleted a comment from github-actions bot Jan 11, 2023
@github-actions
Copy link
Contributor

Incompatible changes

3 changes to com.typesafe.slick:slick since 3.5.0-pre.176.8f41c94f

Code changes

Incompatibility Symbol Problem
Backward slick.jdbc.JdbcBackend#DatabaseDef.releaseSession IncompatibleMethTypeProblem

method releaseSession(slick.basic.BasicBackend#BasicActionContext,Boolean)Unit in class slick.jdbc.JdbcBackend#DatabaseDef's type is different in current version, where it is (slick.basic.BasicBackend#BasicActionContext,scala.PartialFunction)Unit instead of (slick.basic.BasicBackend#BasicActionContext,Boolean)Unit
Backward slick.memory.DistributedBackend#DatabaseDef.releaseSession IncompatibleMethTypeProblem

method releaseSession(slick.basic.BasicBackend#BasicActionContext,Boolean)Unit in class slick.memory.DistributedBackend#DatabaseDef's type is different in current version, where it is (slick.basic.BasicBackend#BasicActionContext,scala.PartialFunction)Unit instead of (slick.basic.BasicBackend#BasicActionContext,Boolean)Unit
Backward slick.memory.HeapBackend#DatabaseDef.releaseSession IncompatibleMethTypeProblem

method releaseSession(slick.basic.BasicBackend#BasicActionContext,Boolean)Unit in class slick.memory.HeapBackend#DatabaseDef's type is different in current version, where it is (slick.basic.BasicBackend#BasicActionContext,scala.PartialFunction)Unit instead of (slick.basic.BasicBackend#BasicActionContext,Boolean)Unit

@nafg nafg linked an issue Jan 11, 2023 that may be closed by this pull request
ManagedArrayBlockingQueue permanently reduces throughput when session release throws #2430
Closed
@nafg nafg marked this pull request as ready for review January 11, 2023 23:34
@mergify mergify bot merged commit ddd378e into main Jan 11, 2023
@mergify mergify bot deleted the issue-2430 branch January 11, 2023 23:34
@nafg nafg added the bug label Jan 11, 2023
@nafg nafg added this to the 3.5.0 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

ManagedArrayBlockingQueue permanently reduces throughput when session release throws
1 participant
@nafg