Add exceptionOverrideClassName config for HikariCP #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nafg
force-pushed
the
add_hikaricp_exception_override
branch
from
b904ffd
to
ddc9030
Compare
|
There are no incompatible changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to use HikariCP's exception override function.
https://github.com/brettwooldridge/HikariCP/blob/58b87f4be23642dffd7daca912de23b8bc25f44b/src/main/java/com/zaxxer/hikari/HikariConfig.java#L877
Usecase of this is for avoiding to evict connection when some SQLException is occurred.
AWS JDBC Driver for MySQL is one of the example that needs the function.
https://github.com/awslabs/aws-mysql-jdbc#connection-pooling