Restore Java 8 support #2622
Merged
Restore Java 8 support #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no incompatible changes |
1 similar comment
|
There are no incompatible changes |
|
Doesn't sacrifice much I guess, why not... for now, anyway |
nafg
force-pushed
the
reinstate-jdk-8
branch
2 times, most recently
from
45ccf21
to
7472146
Compare
|
Should be merged immediately before releasing so Scala Steward doesn't undo it first |
|
Actually we should try to keep this until final so we need to configure Scala Steward |
Roll back hsqldb driver, hikaricp, and logback versions for java 8 support
nafg
force-pushed
the
reinstate-jdk-8
branch
from
7472146
to
cc619a3
Compare
Incompatible changes
com.typesafe.slick:slick-hikaricp
since 3.5.0-pre.156.b6af874c
|
| Incompatibility | Artifact | Previous version | Current version | Version scheme |
|---|---|---|---|---|
| Backward and forward | com.zaxxer:HikariCP |
5.0.1 | 4.0.3 | Early semantic versioning |
1 change to com.typesafe.slick:slick-testkit
since 3.5.0-pre.156.b6af874c
com.typesafe.slick:slick-testkit
since 3.5.0-pre.156.b6af874c
Dependency changes
| Incompatibility | Artifact | Previous version | Current version | Version scheme |
|---|---|---|---|---|
| Backward and forward | com.zaxxer:HikariCP |
5.0.1 | 4.0.3 | Early semantic versioning |
Never mind, Scala Steward PRs should fail with this so they won't get merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opinions, please!