Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inserting / updating 1-elem HLists #658

Closed
wants to merge 1 commit into from
Closed

Conversation

cvogt
Copy link
Member

@cvogt cvogt commented Feb 6, 2014

@cvogt
Copy link
Member Author

cvogt commented Feb 6, 2014

This fixes the issue. Hoewever, we may want to fix the place where a ProductResultConverter is created for this case instead.@szeiger WDYT?

@szeiger
Copy link
Member

szeiger commented Feb 6, 2014

There's some special handling for single elements somewhere but this change makes update and set in ProductResultConverter different from read (which always builds a tuple, even a Tuple1). I'll need to take a closer look.

szeiger added a commit that referenced this pull request Feb 6, 2014
The new query compiler can deal perfectly well with nested products,
so there is no more need for ugly hacks that fail for products of
size 1.

We can now also add a Shape for Tuple1 for completeness.

Fixes issue #658. Tests in JdbcMapperTest.testSingleElement.
@cvogt
Copy link
Member Author

cvogt commented Feb 7, 2014

closing in favor of #661

@cvogt cvogt closed this Feb 7, 2014
@cvogt cvogt deleted the tmp/fix-1elem-hlist branch February 7, 2014 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants