Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gettransaction RPC event queue #68

Open
wtogami opened this issue May 13, 2015 · 0 comments
Open

Implement gettransaction RPC event queue #68

wtogami opened this issue May 13, 2015 · 0 comments

Comments

@wtogami
Copy link
Collaborator

wtogami commented May 13, 2015

A rescan with a large quantity of wallet transactions or a massive flood of new transactions could trigger many near-simultaneous walletnotify events, which in turn would get stuck for a while with many parallel RPC calls waiting for bitcoind.

This is nowhere near fatal to Baron 0.9.3. I suspect the logs would be a mess, but Baron handles this just fine and will eventually recover on its own even if random gettransaction RPC calls fail due to the later listsinceblock that discovers previously missed 0-conf transactions.

It would be technically best if walletnotify added the txid's to a queue without delay, and a separate event loop processed each txid one at a time.

@wtogami wtogami changed the title Implement RPC event queue Implement gettransaction RPC event queue May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant