fix: remote assets

slidevjs · Apr 28, 2021 · 35d5696 · 35d5696
1 parent 037fec0
commit 35d5696
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 13 deletions.
diff --git a/packages/slidev/node/parser.ts b/packages/slidev/node/parser.ts
@@ -122,7 +122,7 @@ export function parse(
 
   config.theme ??= headmatter.theme ?? 'default'
   config.title ??= headmatter.title ?? (slides[0].content.match(/^# (.*)$/m)?.[1] || '').trim()
-  config.remoteAssets ??= headmatter.remoteAssets ?? 'dev'
+  config.remoteAssets ??= headmatter.remoteAssets ?? true
   config.monaco ??= headmatter.monaco ?? 'dev'
 
   return {

diff --git a/packages/slidev/node/plugins/preset.ts b/packages/slidev/node/plugins/preset.ts
@@ -145,6 +145,7 @@ export function ViteSlidevPlugin(
           },
         ],
         resolveMode: '@fs',
+        awaitDownload: mode === 'build',
         ...remoteAssetsOptions,
       })
       : null,

diff --git a/packages/slidev/package.json b/packages/slidev/package.json
@@ -67,7 +67,7 @@
     "vite-plugin-components": "^0.8.4",
     "vite-plugin-icons": "^0.5.0",
     "vite-plugin-md": "^0.6.3",
-    "vite-plugin-remote-assets": "^0.1.5",
+    "vite-plugin-remote-assets": "^0.2.0",
     "vite-plugin-windicss": "^0.15.7",
     "vue": "^3.0.11",
     "windicss": "^2.5.14",
@@ -93,7 +93,7 @@
     "playwright": "^1.10.0",
     "pnpm": "^6.2.2",
     "rimraf": "^3.0.2",
-    "tsup": "^4.10.0",
+    "tsup": "^4.10.1",
     "typescript": "^4.2.4"
   }
 }
diff --git a/packages/types/types.d.ts b/packages/types/types.d.ts
@@ -22,8 +22,17 @@ export interface ParseOptions {
 
 export interface SlidevConfig {
   title: string
+  /**
+   * @defult 'default'
+   */
   theme: string
-  remoteAssets: boolean | 'dev'
+  /**
+   * @defult true
+   */
+  remoteAssets: boolean | 'dev' | 'build'
+  /**
+   * @defult 'dev'
+   */
   monaco: boolean | 'dev'
 }
 

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml