Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fixes #1238
fixes #1278
Previously, the resolving utilities were messed up, and not all the cases (like global installation and
@/
) are handled properly. This PR fixes that by refactoring the path-resolving utilities.Changes
packages/slidev/node/resolver.ts
@/
work properlyResolveuserRoot
,cliRoot
, andclientRoot
at module level. So that we don't need to pass them around anymoreTest Plan
slidev
slidev build
slidev export
/slidev export-notes
slidev format
slidev theme eject
Todos