Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presenter cursor lacks contrast on dark backgrounds (images) #1477

Closed
franky47 opened this issue Mar 29, 2024 · 0 comments · Fixed by #1478
Closed

Presenter cursor lacks contrast on dark backgrounds (images) #1477

franky47 opened this issue Mar 29, 2024 · 0 comments · Fixed by #1478

Comments

@franky47
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

The presenter cursor can lack contrast against dark backgrounds in light mode, and light backgrounds in dark mode.

To Reproduce
Steps to reproduce the behavior:

  1. Open Slidev in demo mode (pnpm demo:dev), and toggle the theme
  2. Observe the cursor against different backgrounds

Here's an example, where in dark mode (white cursor), the contrast is acceptable:

slidev demo with white cursor visible against a leaf background

But switching to light mode turns the cursor completely black, which lacks contrast against the same background:

slidev demo with a black cursor barely visible, outlined for easier detection

Another demo of the issue which happened live while presenting (though the light/dark theme was a saver for bad projector contrast, kudos for that!):
https://youtu.be/PEWtI5PwQ30&t=58

Desktop (please complete the following information):

  • OS: macOS 12.7.3
  • Browser: Firefox 124
  • Slidev version: 0.48.7 (built from source from the main branch at time of opening the issue)

Suggestion

I fixed it locally by adding a contrasting stroke on the cursor icon:

CleanShot 2024-03-29 at 09 56 48@2x CleanShot 2024-03-29 at 09 57 29@2x

I'll open a PR with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant