feat: apply real resize to mermaid graphs #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the possibility to change the alignment of the Mermaid diagram (when scale is applied). The options are: 'left', 'center', or 'right' [default: 'left']
|
Thanks for your reactivity! :) I enjoy to see the professional way of implementing that feature! Thanks, have a great day! Note: small typo in your code "acutalHeight.value" instead of "actualHeight.value" |
|
Typo fixed, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here comes another way to scale the SVG generated by MermaidJS. As it is done now, the Transform component wrapping the Mermaid component makes it difficult to position the generated SVG when scaled.
I proposed a simple addition (#218) to expose the alignment option to the user. But it may still be unsufficient in some cases (vertical adjustments for instance)
The present PR proposes a way to actually scale directly the SVG and remove the Transform component. The generated SVG become then much easier to position.
Feel free to reject both PRs if this does not make any sense. (I personally prefer this second PR)
Have a good day!
/CN