Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-click-hide): the route for v-click-hide #276

Merged
merged 4 commits into from
Aug 11, 2021

Conversation

WingLim
Copy link
Contributor

@WingLim WingLim commented Jun 22, 2021

v-click-hide route not work, because elements has nothig.

Fix it as how v-click work.

Fix #323.

WingLim pushed a commit to WingLim/slidev that referenced this pull request Jun 22, 2021
@antfu
Copy link
Member

antfu commented Jul 25, 2021

Sorry I am a bit out-of-context right now. Does this PR still relevant?

@WingLim
Copy link
Contributor Author

WingLim commented Aug 9, 2021

Sorry I am a bit out-of-context right now. Does this PR still relevant?

The v-click-hide hide all element, instead of one by one.
Because there has no elements to control it.

@WingLim
Copy link
Contributor Author

WingLim commented Aug 9, 2021

However, maybe we could remove v-click-hide, because the v-click directive already has the hide option to hide one element and show after one click.

@antfu antfu merged commit b499243 into slidevjs:main Aug 11, 2021
@WingLim WingLim deleted the fix/v-click-hide branch September 6, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v-click-hide not working
2 participants