Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: perform terminal shortcuts on keypress #393

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

wrongsahil
Copy link
Contributor

@wrongsahil wrongsahil commented Nov 7, 2021

Why?

Right now we need to press r/o/e and then press enter to perform the shortcut. It should be better to just perform the shortcut on keypress event

PS: While running dev server, we still need to press enter every time, since nodemon is also waiting for keys to be pressed (i.e. "rs" to restart server), we're running into a conflict because nodemon has commandeered process.stdin.

@wrongsahil wrongsahil changed the title Enhancement: Perform terminal shortcuts on keypress feat: Perform terminal shortcuts on keypress Nov 7, 2021
@antfu antfu changed the title feat: Perform terminal shortcuts on keypress feat: perform terminal shortcuts on keypress Nov 7, 2021
@antfu antfu merged commit e46e325 into slidevjs:main Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants