Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index and delete routes were replaced by scripts #8

Merged
merged 2 commits into from
Jun 30, 2017
Merged

index and delete routes were replaced by scripts #8

merged 2 commits into from
Jun 30, 2017

Conversation

schatzopoulos
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.1%) to 30.719% when pulling a8741a3 on SWIK-1508_move_index_and_delete_routes_to_scripts into 3d12c72 on master.

@bwulff
Copy link
Member

bwulff commented Jun 28, 2017 •
edited
Loading

Looks good! @schatzopoulos can the scripts be called with docker exec ...? Did you try?

@kprist
Copy link
Member

kprist commented Jun 28, 2017

@bwulff @schatzopoulos I would assume if node is in the docker container path, docker exec bin/index etc should work

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.0%) to 30.818% when pulling bca3e0a on SWIK-1508_move_index_and_delete_routes_to_scripts into 72bffe4 on master.

@schatzopoulos schatzopoulos merged commit 98d7ad9 into master Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwulff bwulff bwulff approved these changes

@kprist kprist kprist approved these changes

Assignees

@bwulff bwulff

@kprist kprist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@schatzopoulos @coveralls @bwulff @kprist