Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Manifest v6 #35

Closed
reegs opened this issue Jul 28, 2022 · 2 comments · Fixed by #37
Closed

Add support for Manifest v6 #35

reegs opened this issue Jul 28, 2022 · 2 comments · Fixed by #37

Comments

@reegs
Copy link

reegs commented Jul 28, 2022

dbt has released version 1.2 and bumped the manifest version to v6 as part of this release.

They have allowed manifest v6 to defer to v4 and v5 of the manifest which means that changes are not breaking. They are related to adding information about configs and metrics. Neither of these are currently consumed from the manifest by dbt coverage

I believe this means dbt-coverage can add manifest v6 support without fundamental changes to the project
sweco added a commit that referenced this issue Jul 29, 2022
@sweco
#35 Add support for dbt==1.2
b5d34d4
sweco added a commit that referenced this issue Jul 29, 2022
@sweco
#35 Add support for dbt==1.2
147fd88
@sweco
Copy link
Collaborator

sweco commented Jul 29, 2022

Hey @reegs, thanks for reporting the issue and checking the status. I'll add manifest v6 to the list of supported versions.

@sweco sweco mentioned this issue Jul 29, 2022
Merged
sweco added a commit that referenced this issue Jul 29, 2022
@sweco
#35 Add support for dbt==1.2
93f0372
sweco added a commit that referenced this issue Jul 29, 2022
@sweco
#35 Add support for dbt==1.2
e5c0fda
@sweco sweco closed this as completed in #37 Jul 29, 2022
sweco added a commit that referenced this issue Jul 29, 2022
@sweco
#35 Add support for dbt==1.2
c22bc09
@reegs
Copy link
Author

reegs commented Jul 31, 2022

Thank you @sweco !

@followingell followingell mentioned this issue Oct 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for dbt==1.2 slidoapp/dbt-coverage
2 participants
@reegs @sweco