Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow model filtering #45
Allow model filtering #45
Changes from 13 commits
9d10d2b
6dbaebc
408d3e1
545b8c8
4e8c77c
fb7c0eb
a96fa79
bf4f107
7d90c1c
5a633d5
6704fc6
bd31ca0
bf2c0b9
6f28ff2
8e1efc6
fc06bd7
903ce3a
9823d80
ca47a9d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@followingell how would you feel about changing this to
table.original_file_path.startswith(path)
? I am mostly concerned about the unintended consequences of having say thestaging/
andpre-staging/
folders in one's project and as it currently is, I am afraid--model-path-filter staging/
would cover both.Alternatively, having a regex option would certainly work too 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrshu Again, great thoughts r.e. covering both
staging/
andpre-staging/
unintentionally when using--model-path-filter staging/
with my previous implementation.As per your suggestion I have swapped the code to use
startswith
and had this reflected in the README since this provides as much control as before whilst reducing the potential for unintended inclusions as outlined above.