Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag filtering option for dbt-coverage users #75

Closed
wants to merge 4 commits into from

Conversation

chrishronek
Copy link

@chrishronek chrishronek commented Mar 8, 2024

Not sure if you're taking oss contributions. I saw that you had path filtering, but this would allow users to filter their reports to a specific tag which would fit our use case for dbt-coverage. Great project, btw!

Usage:

dbt-coverage compute doc --cov-report coverage-test.json --model-tag-filter tag:<put-your-dbt-tag-here>

@sweco
Copy link
Collaborator

sweco commented Mar 13, 2024

Hey @chrishronek, thanks for your PR, we're definitely accepting contributions. 😊

Thinking about the added functionality, wouldn't it be sufficient to simply run the dbt docs generate only for the selected tag, i.e. dbt docs generate --select tag:<tag>? I'm just thinking whether it's a good idea to replicate functionality from dbt. We already did this once - #45 - but I think it's mostly only more code to maintain without much added value.

@chrishronek
Copy link
Author

chrishronek commented Mar 18, 2024

Hey @chrishronek, thanks for your PR, we're definitely accepting contributions. 😊

Thinking about the added functionality, wouldn't it be sufficient to simply run the dbt docs generate only for the selected tag, i.e. dbt docs generate --select tag:<tag>? I'm just thinking whether it's a good idea to replicate functionality from dbt. We already did this once - #45 - but I think it's mostly only more code to maintain without much added value.

Frankly, I'm a little embarrassed that I didn't think of that myself 😅. I'm going to go ahead and close. Thanks for the response!

@chrishronek chrishronek deleted the add-tag-filtering branch March 18, 2024 16:08
@sweco
Copy link
Collaborator

sweco commented Mar 19, 2024

No worries at all! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants