fix: read selected skin tone #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanPodmajersky
requested changes
Jun 17, 2024
andrejkaPry
force-pushed
the
andrejka/PS-20646-read-selected-option
branch
3 times, most recently
from
3708bd4
to
3f641ed
Compare
JanPodmajersky
force-pushed
the
andrejka/PS-20646-read-selected-option
branch
from
3f641ed
to
3a2d338
Compare
Choose default skin tone button was announced without the selected option, which is not a11y friendly. According [rules](https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-select-only/) the already selected option should be read as well even before doing the action click. Related to - PS-20646, PS-20687
JanPodmajersky
force-pushed
the
andrejka/PS-20646-read-selected-option
branch
from
3a2d338
to
29ef2a0
Compare
JanPodmajersky
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose default skin tone button was announced without the selected option, which is not a11y friendly. According rules the already selected option should be read as well even before doing the action click.
Related to - PS-20646, PS-20687