Fix #380: Require a javascript content-type. #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you list them in arbitrary order, list Also, you need to talk about parsing the Content-Type header somehow and what to do if there any parameters. |
|
Thanks. How's this? |
|
Looks good. I think if you say "one of" you need to use "and" though, and not "or". |
jungkees
added a commit
that referenced
this pull request
Aug 8, 2014
Fix #380: Require a javascript content-type. Thanks! @annevk It seems "one of" is used with both "and" and "or". e.g. http://www.whatwg.org/specs/web-apps/current-work/multipage/syntax.html#parsing-main-inhtml
|
@jungkees you missed the improvements in your merging. |
Could you explain why? (Is that what you pointed as improvements?) |
|
Because it's one of "a list" and you don't describe a list using "or". Anyway, as far as I know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to double-check that we want to omit the
*/ecmascriptcontent types defined by http://www.rfc-editor.org/rfc/rfc4329.txt. Nothing else from http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting.html#scriptingLanguages looks like a good idea.