Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort/sorted, reverse/reversed both accept &mut self #2

Closed
gavento opened this issue Aug 3, 2019 · 0 comments · Fixed by #3
Closed

sort/sorted, reverse/reversed both accept &mut self #2

gavento opened this issue Aug 3, 2019 · 0 comments · Fixed by #3

Comments

@gavento
Copy link
Contributor

gavento commented Aug 3, 2019

StaticVec::reversed(&mut self)->StaticVec<..> probably should not accept &mut self but only &self to indicate that the original instance does not change. The same for sorted_.... It may be easy to confuse reversed with e.g. "a reverse that also returns Self".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant