Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/navbar #14

Merged
merged 12 commits into from
Oct 13, 2020
Merged

Feature/navbar #14

merged 12 commits into from
Oct 13, 2020

Conversation

sithumonline
Copy link
Member

Remake navbar and footer with primer css

@chamodshehanka
Copy link
Member

@ebonynon provide screenshots

Copy link
Member

@chamodshehanka chamodshehanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@chamodshehanka chamodshehanka added the hacktoberfest-accepted Hacktoberfest PR Accepted label Oct 13, 2020
@sithumonline
Copy link
Member Author

image

Comment on lines +6 to +20
<h5 class="text-uppercase">Links</h5>
<ul>
<li>
<a href="#!">Link 1</a>
</li>
<li>
<a href="#!">Link 2</a>
</li>
<li>
<a href="#!">Link 3</a>
</li>
<li>
<a href="#!">Link 4</a>
</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add our social media links with icons

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Safnaj
Copy link
Member

Safnaj commented Oct 13, 2020

Better to keep bootstrap too
and also change the navbar active color to chamod's favourite purple

@sithumonline
Copy link
Member Author

image

@chamodshehanka chamodshehanka merged commit b743289 into master Oct 13, 2020
@chamodshehanka chamodshehanka deleted the feature/navbar branch October 13, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest PR Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants